Add support for apps supporting PROCESS_TEXT intents. #3720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the context menu that appears when a user selects text, add a new submenu which includes third-party activities which handle the `PROCESS_TEXT` intent. This will allow processing the selected text in other apps. Some links about this type of interaction with other apps: * Manifest config required to work on Android 30+: https://developer.android.com/training/package-visibility/use-cases * `PROCESS_TEXT` intent action: https://developer.android.com/reference/android/content/Intent#ACTION_PROCESS_TEXT) * Blog post by Ian Lake on how to make an app appear in the system text selection menu: https://medium.com/androiddevelopers/custom-text-selection-actions-with-action-process-text-191f792d2999 Since the text selection menu is customized in termux, if we want the text selection menu to include this functionality, we have to add it ourselves (this commit :) ).
|
Thanks for the pull, this looks good and mergable in essence. Will have to test it and will merge with the others before next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context menu that appears when a user selects text, add a new submenu which includes third-party activities which handle the
PROCESS_TEXTintent. This will allow processing the selected text in other apps.Some links about this type of interaction with other apps:
PROCESS_TEXTintent action: https://developer.android.com/reference/android/content/Intent#ACTION_PROCESS_TEXTSince the text selection menu is customized in termux, if we want the text selection menu to include this functionality, we have to add it ourselves (this PR :) ).
Here's a demo of selecting text, and opening it in Google Translate, then in Wikipedia:
process_text.webm