Add deprecation and future disabling of playstore builds warning to banner #7479

agnostic-apollo · 2021-09-06T20:47:20Z

No description provided.

agnostic-apollo · 2021-09-06T21:31:26Z

Working as desired on playstore v0.101 and Github debug build v0.117. No banner with the later. If any changes need to be made, let me know. An additional newline at the end could be added.

Grimler91 · 2021-09-07T07:01:25Z

I think it could be a bit shorter and rather link to places with more info (to increase the chances of people reading it). Suggestion (with slightly higher column width but not wider than your current resolution):

You are using a very old version of Termux, probably
installed from Google Play Store.  The termux apps will
be removed from Play store in the near future.  Instead
you are encouraged to install from F-Droid or Github
Debug builds (see [1]).  You can backup all your
current data before changing installation source, and
then restore it afterwards, by following instructions
in the wiki [2].  Check the changelog [3] for all the
new features and fixes that you are currently missing.

[1] https://github.com/termux/termux-app#installation
[2] https://wiki.termux.com/wiki/Backing_up_Termux
[3] https://github.com/termux/termux-app/releases

Grimler91 · 2021-09-07T07:02:54Z

packages/termux-tools/login

+
+	# TERMUX_VERSION env variable has been exported since v0.107 and PATH was being set to following value in <0.104. Last playstore version was v0.101.
+	if [ -f @TERMUX_PREFIX@/etc/motd-playstore ] && [ -z "$TERMUX_VERSION" ] && [ "$PATH" = "@TERMUX_PREFIX@/bin:@TERMUX_PREFIX@/bin/applets" ]; then
+		printf '\033[0;31m'; cat @TERMUX_PREFIX@/etc/motd-playstore; printf '\033[0m'
+	fi


Should probably be outside if [ ! -f ~/.hushlogin ] && [ -z "$TERMUX_HUSHLOGIN" ], we want to force people to see the message and really encourage them to move to a more up to date version (even if they have previously silenced the motd)

Yeah that makes sense. I will do it.

agnostic-apollo · 2021-09-07T08:11:20Z

I think it could be a bit shorter and rather link to places with more info (to increase the chances of people reading it).

I was thinking it was a bit lengthy too, but had to provide more info on why moving should be a must now and that they won't lose data during move. Maybe we can make a short wiki page for it too and possibly provide instructions to separately backup home and usr so that they can be done one at a time for people with low storage, possibly with xz compression.

Suggestion (with slightly higher column width but not wider than your current resolution):

I was using the standard 70 CPL before but it was causing wrap around on android 11 avd default config, so I lowered it to around 50.

RalfWerner · 2021-09-07T08:51:06Z

Stupid question: Why should someone get this message when he used an installed Play Store version or does it today?
He would get a problem only at pkg up!

agnostic-apollo · 2021-09-07T09:32:12Z

Because deprecated things get removed after some time, its the standard practice. It's been many months now. Moreover, new versions have lot of new features and bug fixes and users on old versions are often reporting issues in multiple repositories which we then have to deal with. Playstore page of termux-app has been filled with bad reviews of "broken app", even though its clearly mentioned on the page that app is not being updated, cause users often don't bother to read or search. Also asking people to pay for plugins when the app at installation time is broken and has bugs is unethical. Old versions also don't have debugging and crash reports support to actually help solve bugs. Its also easier for us to solve package related issues and provide custom functionality with app updates. The amount of bug reports we have received for that ~~damn~~ bintray issue, that we are actually still receiving reports for on multiple platforms after months, could have been drastically reduced if users had latest bootstrap installed which had working repos. Repo issues could technically also have been solved with an app update by automatically replacing faulty ones with sed but at the time termux-app didn't have such utils implemented to do stuff like that, now termux-shared does, so if similar issues are faced in future, they can be handled.

RalfWerner · 2021-09-07T09:43:56Z

Thanks for your detailed answer - I'm confirm with it!
My question was meant more practic! So the person someone would get the message at all through this PR?

Actually, only with the knowledge of tomorrow the messages can be displayed with a version of today. Example:
Helpful would be a message: [[ "$TERMUX_VERSION" > "0.117" ]]&& cat @TERMUX_PREFIX@/etc/remove-float-widget-apps

Maybe you think again about my boot loop solution? Thus, a SDB 29+ version created, and could used (one last time) as a Playstore update. Even if it is not maintained, the reference to Fdroid, Repo or Self Made could contained (knowledge of today).

finagolfin

Some better wording below.

finagolfin · 2021-09-07T11:30:34Z