termux_step_massage: check built libs for undefined symbols #9790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtkoba
reviewed
Apr 2, 2022
scripts/build/termux_step_massage.sh
Outdated
| if ! readelf -h $lib &> /dev/null; then | ||
| continue | ||
| fi | ||
| if readelf -s $lib | grep "UND $sym" &> /dev/null; then |
There was a problem hiding this comment.
The regexp for this line could be improved:
egrep 'NOTYPE[[:space:]]+GLOBAL[[:space:]]+DEFAULT[[:space:]]+UND[[:space:]]+'$sym'$'where NOTYPE is specified in order to avoid matching "leaked builtins" from other shared libraries, though I suppose they have all been purged now.
Grimler91
force-pushed
the
ndk-r23-undefined-sym-check
branch
from
bd1f66c to
9e84d66
Compare
Building packages that use libtool for linking libraries has issues with ndk-r23 (android/ndk#1614). This check makes sure that the built libraries do not give an error like CANNOT LINK EXECUTABLE "tesseract": cannot locate symbol "__extenddftf2" referenced by "/data/data/com.termux/files/usr/lib/libtesseract.so"... once used on device. In android/ndk#1614 it seemed like arm gave false positives and needed special consideration, but when I tested it again today the same false positives do not occur in built libraries, so no "if arm then .." workaround has been added for now.
Grimler91
force-pushed
the
ndk-r23-undefined-sym-check
branch
from
9e84d66 to
ffa1ed6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building packages that use libtool for linking libraries has issues
with ndk-r23 (android/ndk#1614). This check
makes sure that the built libraries do not give an error like
once used on device. In android/ndk#1614 it
seemed like arm gave false positives and needed special consideration,
but when I tested it again today the same false positives do not occur
in built libraries, so no "if arm then .." workaround has been added
for now.