pass --loglevel to plugins as TFLINT_LOG #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wata727
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
Good catch!
Longer term, removing --loglevel altogether would prevent this from being an issue. Terraform does not have a log level flag, perhaps in part in recognition that environment variables fit better with external plugin processes.
Agreed. Initially, I didn't understand this concern, so it was implemented in #844, but for this reason, I don't think there's any reason to continue to support it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per terraform-linters/tflint-ruleset-aws#69 (comment), when users set a log level via
--loglevel, plugin processes do not reflect this input. This passes it viaTFLINT_LOG.Longer term, removing
--loglevelaltogether would prevent this from being an issue. Terraform does not have a log level flag, perhaps in part in recognition that environment variables fit better with external plugin processes.