Move cli_test.go to integration test #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wata727
force-pushed
the
integration_test_for_cli
branch
from
dc9cc3b to
879ea46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the current mock-based
cmd/cli_test.goand adds integration tests that do the same testing.The purpose of this change is mainly for #1496. Mock-based testing leveraged existing Terraform rules to inject test rules. However, with this change, all rules are provided as plugins, so mock-based tests will no longer work.
Integration tests don't need mocks and will continue to work correctly. In addition, since it does not use mocks, it has the advantage of more accurate testing and the ability to remove gomock and
loader_mock.go.