Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove terraform_dash_in_* rules #737

Merged
merged 1 commit into from
May 10, 2020
Merged

Remove terraform_dash_in_* rules #737

merged 1 commit into from
May 10, 2020

Conversation

wata727
Copy link
Member

@wata727 wata727 commented May 4, 2020

In #697, the terraform_naming_convention rule was introduced. This pull request removes the terraform_dash_in_ * rules that have similar goals.

Strictly speaking, the terraform_naming_convention rule cannot do exactly the same checks as dash rules, but in many cases, the snake_case format seems sufficient. But here is controversial. Please let me know if there is an example that cannot be avoided.

mveitas
mveitas approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@mveitas mveitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wata727 wata727 merged commit c99d23d into master May 10, 2020
@wata727 wata727 deleted the remove_terraform_dash_rules branch May 10, 2020 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mveitas mveitas mveitas approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wata727 @mveitas