-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add terraform_workspace_remote rule #738
Merged
wata727
merged 6 commits into
terraform-linters:master
from
bendrucker:remote-terraform-workspace
May 11, 2020
Merged
add terraform_workspace_remote rule #738
wata727
merged 6 commits into
terraform-linters:master
from
bendrucker:remote-terraform-workspace
May 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendrucker
force-pushed
the
remote-terraform-workspace
branch
from
May 6, 2020 04:23
39ac2d9
to
eec531b
Compare
wata727
reviewed
May 6, 2020
wata727
reviewed
May 6, 2020
This was referenced May 6, 2020
Updated this to use |
wata727
approved these changes
May 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a rule that warns against the use of
terraform.workspace
interpolations when the user has a "remote" backend configured. This backend is used with Terraform Cloud and most TF Cloud users want to execute Terraform remotely. In these circumstances,terraform.workspace
will always evaluate to"default"
. More here:https://www.terraform.io/docs/backends/types/remote.html#workspaces
While you can use the remote backend as a state store and execute Terraform runs locally, this is of limited use and anyone using Terraform Cloud will likely want to move away from
terraform.workspace
for all of their configuration.If
terraform.workspace
does not evaluate to the expected value, Terraform configuration may break or TF may plan unexpected changes.