Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correct onScale method signature in CKCamera.kt #551

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

coreyphillips
Copy link
Contributor

Summary

This PR fixes an issue with the onScale method override in CKCamera.kt file previously discussed here.

The 'onScale' method was attempting to override the interface method with a nullable parameter, causing a mismatch with the parent interface. This change corrects the method signature by changing the nullable parameter to non-nullable, aligning it with the interface and ensuring proper method overriding.

How did you test this change?

  • With this change, a new React Native app at v0.72.0 will now build successfully on Android when the compileSdkVersion is set to 33.

The 'onScale' method was attempting to override the interface method with a nullable parameter, causing a mismatch with the parent interface. This change corrects the method signature by changing the nullable parameter to non-nullable, aligning it with the interface and ensuring proper method overriding.
@scarlac scarlac merged commit 855f23b into teslamotors:master Jun 29, 2023
@scarlac
Copy link
Collaborator

scarlac commented Jun 29, 2023

Thank you, @coreyphillips !

@relm923
Copy link

relm923 commented Jun 30, 2023

@scarlac what's the process for releasing this change? It's blocking us from upgrading ReactNative. Thanks

@scarlac
Copy link
Collaborator

scarlac commented Jul 1, 2023

I recommend temporarily referring to the got commit that includes your change.
You do that by referencing the GitHub repo path appended by a #gitshorthash
Eg: “kiddish”: “kiddish/lodash#1234abc” in your package.json.
We are reviewing a large refactor to the library right now so we may not release a beta until then.

@coreyphillips
Copy link
Contributor Author

@relm923, I created a branch here to use as a temporary v13 patch until the v14 release.

The dist folder is included so feel free to fork and rebuild. Otherwise, it can be used like so:
yarn add github:coreyphillips/react-native-camera-kit#v13-patch

@relm923
Copy link

relm923 commented Jul 3, 2023

Thanks @coreyphillips I ended up using patch-package to only apply this change for now to minimize risk on our end

elliottkember added a commit to elliottkember/react-native-camera-kit that referenced this pull request Oct 3, 2023
teslamotors#559 broke a change in teslamotors#551 regarding override types. This restores the fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants