added code format to see type of code scanned #633
Conversation
There was a problem hiding this comment.
I was planning to do it next week, thanks @android-imdad!
A few feedbacks, but it's looking great. Can you also check the overall syntax, spaces, blank lines, file header, to be consistent with other places?
|
Hi, yes will check these comments in a few days |
Changed supported barcode types to list of CodeFormat Co-authored-by: David Bertet <[email protected]>
Added annotation for int type Co-authored-by: David Bertet <[email protected]>
…h other functions
|
@DavidBertet I fixed the indentation, accepted your changes and added types. Please review and let me know if there are any concerns. |
Thanks @android-imdad. Have you tried it? I doubt the iOS part compiles at all. When I said to replace |
My bad, nope didn't try it after the change. Will test it and do a commit with the fixes. |
|
@DavidBertet Please check now, I made the changes and tested in both IOS and Android, seems to be working as expected. |
There was a problem hiding this comment.
I couldn't test for now, 2 minor feedbacks but the code looks right.
Thanks @android-imdad for your contribution!
| metadataOutput.metadataObjectTypes = filteredTypes | ||
| let filteredTypes = supportedBarcodeType.filter { type in availableTypes.contains(type.toAVMetadataObjectType()) } | ||
|
|
||
| metadataOutput.metadataObjectTypes = filteredTypes.map { $0.toAVMetadataObjectType() } |
There was a problem hiding this comment.
We are doing toAVMetadataObjectType twice for the same objects. Something like that should do the same
let filteredTypes = supportedBarcodeType
.map { $0.toAVMetadataObjectType() }
.filter { availableTypes.contains($0) }
metadataOutput.metadataObjectTypes = filteredTypes
| @@ -184,14 +186,16 @@ class CameraView: UIView { | |||
|
|
|||
| // Scanner | |||
| if changedProps.contains("scanBarcode") || changedProps.contains("onReadCode") { | |||
| let supportedFormats = supportedBarcodeType.map { CodeFormat.fromAVMetadataObjectType($0) } | |||
There was a problem hiding this comment.
We can use CodeFormat for supportedBarcodeType line 23, so no need to map it here
There was a problem hiding this comment.
Oh yes I should have just done that :D
There was a problem hiding this comment.
@DavidBertet check now
… to code format cases
|
Thanks @android-imdad and @DavidBertet ! |
Summary
Added codeFormat to see what kind of code is being scanned, useful when there is code specific validation that needs to be done.
How did you test this change?
Tested example apps on both IOS and Android, no visual change for screenshot.