chore: bump example to rn76 #681
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBertet
reviewed
Dec 21, 2024
.github/workflows/build.yml
Outdated
Comment on lines
32
to
39
| - name: Set up JDK 17 | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: '17' | ||
| distribution: 'zulu' | ||
| cache: 'gradle' | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 |
There was a problem hiding this comment.
To fix the build issue on CI, checkout action needs to be triggered first
Suggested change
| - name: Set up JDK 17 | |
| uses: actions/setup-java@v4 | |
| with: | |
| java-version: '17' | |
| distribution: 'zulu' | |
| cache: 'gradle' | |
| - name: Checkout | |
| uses: actions/checkout@v3 | |
| - name: Checkout | |
| uses: actions/checkout@v3 | |
| - name: Set up JDK 17 | |
| uses: actions/setup-java@v4 | |
| with: | |
| java-version: '17' | |
| distribution: 'zulu' | |
| cache: 'gradle' |
DavidBertet
approved these changes
Dec 21, 2024
example/.prettierrc.js
Outdated
There was a problem hiding this comment.
Should we use the same as the parent one for consistency
|
@DavidBertet looks like everything works correctly now 🚀 |
|
@scarlac this one is looking good. It permits to test the new arch on the sample |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR bumping example app to RN 0.76. I had to bump the java SDK since it is needed by RN now. Also, I changed the autolinking method since it made codegen not find iOS for some reason and the current way is pretty standard in other repos.
How did you test this change?
I run the app on both android and ios and verified it compiles. Change flags to enable new arch and see that it works there too.