-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Seq Module #1276
base: develop
Are you sure you want to change the base?
Add Seq Module #1276
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Very glad you have PRed this in it was on my list of ones to do if someone hadn't :) |
e7da3c7
to
3ee32fd
Compare
3ee32fd
to
085f0ec
Compare
👋🏻 G'Day @montanehamilton , question: what is the use case for having Seq in a TC? I use Seq all the time .. love it! but ... I've never seen a use for it as a test container? I'm really curious to learn why. |
Logging is a requirement and ensuring applications can actually log and that those logs actually get to the logging provider, in this case Seq, is a nice, automated test to have. Maintaining a library that has additional logic in a custom Seq client means one should make sure it actually works against the target provider. |
Hmm .. ok. So if I'm reading this correctly, you're testing that your logging configuration (to seq) is correct? Or you're testing either the MS-Logging to Serilog-Logging method you're using to log .. works? |
Implicitly we're "testing" those perhaps but the point is to ensure the values we expect on our logs get logged. We're really testing how we're using those methods and doing an automated integration test to assert it's all working correctly and we're sending the expected properties. No different to using a database container to run an integration test for our application even though we use Entity Framework or Dapper. Regardless of them "working" how you use them matters. |
5daf65c
to
e9be189
Compare
e9be189
to
8cad0fb
Compare
What does this PR do?
New module to support the Seq logging server.
Why is it important?
Another module to make it easy for developers needing Seq to get testing quickly.
How to test this PR
Automated test added to demonstrate the Seq server accepts logs and that those logs can be read via the API.