Use host port zero when setting up PortBindings

Fixes #4395
testcontainers · Aug 26, 2021 · 7fc458a · 7fc458a
1 parent 1699e47
commit 7fc458a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/core/src/main/java/org/testcontainers/containers/GenericContainer.java b/core/src/main/java/org/testcontainers/containers/GenericContainer.java
@@ -753,7 +753,7 @@ private void applyConfiguration(CreateContainerCmd createCommand) {
         // First collect all the randomized host ports from our 'exposedPorts' field
         for (final Integer tcpPort : exposedPorts) {
             ExposedPort exposedPort = ExposedPort.tcp(tcpPort);
-            allPortBindings.put(exposedPort, new PortBinding(Ports.Binding.empty(), exposedPort));
+            allPortBindings.put(exposedPort, new PortBinding(Ports.Binding.bindPort(0), exposedPort));
         }
         // Next collect all the fixed host ports from our 'portBindings' field, overwriting any randomized ports so that
         // we don't create two bindings for the same container port.

diff --git a/core/src/main/java/org/testcontainers/utility/ResourceReaper.java b/core/src/main/java/org/testcontainers/utility/ResourceReaper.java
@@ -107,7 +107,7 @@ public static String start(DockerClient client) {
                 .withHostConfig(
                     new HostConfig()
                         .withAutoRemove(true)
-                        .withPortBindings(new PortBinding(Ports.Binding.empty(), ryukExposedPort))
+                        .withPortBindings(new PortBinding(Ports.Binding.bindPort(0), ryukExposedPort))
                 )
                 .withExposedPorts(ryukExposedPort)
                 .withName("testcontainers-ryuk-" + DockerClientFactory.SESSION_ID)