-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Gradle 7 #4171
Merged
Update to Gradle 7 #4171
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d96795a
Update to Gradle 7
bsideup 9afaab9
Add `checkPOMdependencies` task to test that no new dependencies were…
bsideup 63876f8
Update examples to Gradle 7
bsideup 56e238f
Disable the filesystem watching
bsideup e7d7e28
Try Gradle 7.0.2
bsideup 1057565
fix `provided` configuration
bsideup de76bbc
Extract `ComparePOMWithLatestReleasedTask`
bsideup 071a94f
Merge branch 'master' into gradle_7
bsideup 3f838e5
Add missing file
bsideup File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-6.5-bin.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-7.0.2-bin.zip | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
org.gradle.parallel=false | ||
org.gradle.caching=true | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
description = "TestContainers :: Cassandra" | ||
|
||
dependencies { | ||
compile project(":database-commons") | ||
compile "com.datastax.cassandra:cassandra-driver-core:3.7.1" | ||
api project(":database-commons") | ||
api "com.datastax.cassandra:cassandra-driver-core:3.7.1" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
description = "Testcontainers :: JDBC :: ClickHouse" | ||
|
||
dependencies { | ||
compile project(':testcontainers') | ||
compile project(':jdbc') | ||
api project(':testcontainers') | ||
api project(':jdbc') | ||
|
||
testCompile project(':jdbc-test') | ||
testCompile 'ru.yandex.clickhouse:clickhouse-jdbc:0.2.4' | ||
testImplementation project(':jdbc-test') | ||
testImplementation 'ru.yandex.clickhouse:clickhouse-jdbc:0.2.4' | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
description = "Testcontainers :: JDBC :: CockroachDB" | ||
|
||
dependencies { | ||
compile project(':jdbc') | ||
api project(':jdbc') | ||
|
||
testCompile project(':jdbc-test') | ||
testCompile 'org.postgresql:postgresql:42.2.12' | ||
testImplementation project(':jdbc-test') | ||
testImplementation 'org.postgresql:postgresql:42.2.12' | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
description = "Testcontainers :: Couchbase" | ||
|
||
dependencies { | ||
compile project(':testcontainers') | ||
api project(':testcontainers') | ||
|
||
testCompile 'com.couchbase.client:java-client:2.7.15' | ||
testImplementation 'com.couchbase.client:java-client:2.7.15' | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
description = "Testcontainers :: Database-Commons" | ||
|
||
dependencies { | ||
compile project(':testcontainers') | ||
api project(':testcontainers') | ||
|
||
testCompile 'org.assertj:assertj-core:3.18.1' | ||
testImplementation 'org.assertj:assertj-core:3.18.1' | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
description = "Testcontainers :: JDBC :: DB2" | ||
|
||
dependencies { | ||
compile project(':jdbc') | ||
api project(':jdbc') | ||
|
||
testCompile project(':jdbc-test') | ||
testCompile 'com.ibm.db2:jcc:11.5.0.0' | ||
testImplementation project(':jdbc-test') | ||
testImplementation 'com.ibm.db2:jcc:11.5.0.0' | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
description = "Testcontainers :: Dynalite" | ||
|
||
dependencies { | ||
compile project(':testcontainers') | ||
api project(':testcontainers') | ||
|
||
compileOnly 'com.amazonaws:aws-java-sdk-dynamodb:1.11.1018' | ||
testCompile 'com.amazonaws:aws-java-sdk-dynamodb:1.11.929' | ||
testImplementation 'com.amazonaws:aws-java-sdk-dynamodb:1.11.929' | ||
|
||
testCompile 'org.rnorth.visible-assertions:visible-assertions:2.1.2' | ||
testImplementation 'org.rnorth.visible-assertions:visible-assertions:2.1.2' | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
description = "TestContainers :: elasticsearch" | ||
|
||
dependencies { | ||
compile project(':testcontainers') | ||
testCompile "org.elasticsearch.client:elasticsearch-rest-client:7.12.1" | ||
testCompile "org.elasticsearch.client:transport:7.12.1" | ||
testCompile 'org.rnorth.visible-assertions:visible-assertions:2.1.2' | ||
api project(':testcontainers') | ||
testImplementation "org.elasticsearch.client:elasticsearch-rest-client:7.12.1" | ||
testImplementation "org.elasticsearch.client:transport:7.12.1" | ||
testImplementation 'org.rnorth.visible-assertions:visible-assertions:2.1.2' | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,12 @@ | ||
description = "Testcontainers :: GCloud" | ||
|
||
dependencies { | ||
compile project(':testcontainers') | ||
api project(':testcontainers') | ||
|
||
testCompile 'com.google.cloud:google-cloud-datastore:1.102.4' | ||
testCompile 'com.google.cloud:google-cloud-firestore:1.33.0' | ||
testCompile 'com.google.cloud:google-cloud-pubsub:1.105.0' | ||
testCompile 'com.google.cloud:google-cloud-spanner:1.50.0' | ||
testCompile 'com.google.cloud:google-cloud-bigtable:1.17.3' | ||
testCompile 'org.assertj:assertj-core:3.15.0' | ||
testImplementation 'com.google.cloud:google-cloud-datastore:1.102.4' | ||
testImplementation 'com.google.cloud:google-cloud-firestore:1.33.0' | ||
testImplementation 'com.google.cloud:google-cloud-pubsub:1.105.0' | ||
testImplementation 'com.google.cloud:google-cloud-spanner:1.50.0' | ||
testImplementation 'com.google.cloud:google-cloud-bigtable:1.17.3' | ||
testImplementation 'org.assertj:assertj-core:3.15.0' | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
description = "Testcontainers :: InfluxDB" | ||
|
||
dependencies { | ||
compile project(':testcontainers') | ||
api project(':testcontainers') | ||
|
||
compileOnly 'org.influxdb:influxdb-java:2.21' | ||
testCompile 'org.influxdb:influxdb-java:2.21' | ||
testImplementation 'org.influxdb:influxdb-java:2.21' | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we make this exception message more helpful for contributors?
e.g.
What do we expect the process to be - do we need to be approving new dependencies somehow?
BTW I think it would be good to move this to a separate
.gradle
file, so that areas of major scripting are encapsulated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion! We could, yes 👍
FYI this message is mostly for us, maintainers, as the chance of an external dependency added by external contributors is super low
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extracted and made the message more user friendly 👍