Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KafkaContainer with multiple networks defined #4213

Merged
merged 2 commits into from
Jun 30, 2021
Merged

Fix KafkaContainer with multiple networks defined #4213

merged 2 commits into from
Jun 30, 2021

Commits on Jun 23, 2021

  1. Current implementation exposes only two listeners PLAINTEXT and BROKE…

    …R.BROKER must be advertised to explicitly specified network or bridge. If a host port is exposed using Testcontainers.exposeHostPorts and a network is specified, the container will be "attached" to an additional network, creating to listeners with the same name
    
    Configure the BROKER listener using the network specified (withNetwork) or "bridge" if not specified, instead of iterating over all the networks in the container info. Additional test cases when a port of the host is exposed (proxy container started) and a external network is specified to the container placing multiple network entries in the container info, making additional Kafka Broker listener entries with the same name "BROKER"
    DennisFederico committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    093b1b0 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2021

  1. Update KafkaContainer.java

    bsideup authored Jun 29, 2021
    Configuration menu
    Copy the full SHA
    3834c04 View commit details
    Browse the repository at this point in the history