Fallback to x86 image if image pulling fails #4290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnorth
reviewed
Jul 19, 2021
| try { | ||
| pullImageCmd.exec(new TimeLimitedLoggedPullImageResultCallback(log)).awaitCompletion(); | ||
| } catch (DockerClientException e) { | ||
| // Try to fallback to x86 |
There was a problem hiding this comment.
Should we log that we're doing this?
There was a problem hiding this comment.
On a second thought (and a round of discussions on Slack), logging this would require a bit more work, so let's keep it as it is right now and do a follow up later 😅
rnorth
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that, to make it work, we need to use Docker API version 1.32 or newer.
1.32 got released in Docker 17.09 (2017-09-26), which is almost 4 years old.
Not as old as Java 8, of course, but still old enough to be considered widely adopted :D