Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ryuk image to 0.3.2 #4359

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Upgrade ryuk image to 0.3.2 #4359

merged 2 commits into from
Aug 3, 2021

Conversation

rnorth
Copy link
Member

@rnorth rnorth commented Aug 3, 2021

Includes testcontainers/moby-ryuk#25, for better cleanup of images built by Testcontainers.

@rnorth rnorth added the dependencies Pull requests that update a dependency file label Aug 3, 2021
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use some old ryuk images (hosted on quay.io) in ImagePullTest, should we update those as well? Or is their use case in the test more for pulling images from other registries?

@rnorth
Copy link
Member Author

rnorth commented Aug 3, 2021

@kiview I don't think so - if it's on quay it's deprecated in our view, and we can just leave it untouched.

@rnorth rnorth merged commit 12b4127 into master Aug 3, 2021
@delete-merged-branch delete-merged-branch bot deleted the upgrade-ryuk branch August 3, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants