Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrientDB: Use log wait strategy for more reliable readiness detection #4471

Merged
merged 6 commits into from
Oct 11, 2021

Conversation

rnorth
Copy link
Member

@rnorth rnorth commented Sep 20, 2021

TODO: check whether this log message is universally applicable or whether we need to include an alternative string to match for

@rnorth
Copy link
Member Author

rnorth commented Sep 20, 2021

Interesting; I thought we'd be able to look for .*(OrientDB Server is active|Gremlin started correctly).* but it appears that the first of these two strings only appears in the logs when using an interactive run of the cotainer (i.e. docker run -i ...).

As far as I can tell Gremlin started correctly is the string we should be looking for.

@rnorth rnorth marked this pull request as ready for review September 20, 2021 12:09
@kiview
Copy link
Member

kiview commented Sep 20, 2021

Further, these logs strongly indicate that network connectivity is provided before general application readiness:

2021-09-20 12:34:53:131 INFO  Listening binary connections on 0.0.0.0:2424 (protocol v.37, socket=default) [OServerNetworkListener]
2021-09-20 12:34:53:134 INFO  Listening http connections on 0.0.0.0:2480 (protocol v.10, socket=default) [OServerNetworkListener]
2021-09-20 12:34:53:136 INFO  Found ORIENTDB_ROOT_PASSWORD variable, using this value as root's password [OServer]
2021-09-20 12:34:53:455 INFO  Installing dynamic plugin 'orientdb-etl-3.0.24.jar'... [OServerPluginManager]
2021-09-20 12:34:53:459 INFO  Installing dynamic plugin 'orientdb-studio-3.0.24.zip'... [OServerPluginManager]

In this case, the Gremlin log you suggested to use is logged 2 seconds later. So this should provide much better reliability.

@rnorth rnorth requested a review from kiview September 20, 2021 14:27
@kiview kiview added this to the next milestone Oct 11, 2021
@kiview kiview merged commit 33218e7 into master Oct 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the orientdb-log-wait branch October 11, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants