Remove unused @ClassRule
container in KafkaContainerTest
and use cp-kafka:6.2.1
as default
#4564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we still saw some flakiness from
KafkaContainerTest
in our CI, I tried to remove some of the elements that I thought of as unnecessary.The
@ClassRule
annotated container was never used in any tests and was just left there for the sake of including its code in the documentation. IMO it is not useful to add test framework integration to each container module documentation, since it is not specific for the container.The update to
cp-kafka:6.2.1
was done to use a container-aware JVM so we have better guarantees for the memory configuration. Accordingly, I changed the testtestConfluentPlatformVersion6
test to check instead compatibility with platform version 5, although we could consider removing this as well?I also removed the test for the deprecated tag version constructor, but if you still want to guard against potential regressions, we can of course keep it.