Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an API to force access to the host #4584

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Conversation

bsideup
Copy link
Member

@bsideup bsideup commented Oct 14, 2021

Before this change, one of the biggest limitations of host port exposing
was that the ports had to be exposed before the container starts.

This change allows forcing starting the forwarding container,
so that host listeners can be started/exposed after starting the consumer.

Before this change, one of the biggest limitations of host port exposing
was that the ports had to be exposed before the container starts.

This change allows forcing starting the forwarding container,
so that host listeners can be started/exposed after starting the consumer.
@bsideup bsideup added this to the next milestone Oct 14, 2021
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super helpful improvement for the API 👍 . We need to update the docs accordingly.

@bsideup
Copy link
Member Author

bsideup commented Oct 18, 2021

@kiview added a mention to the docs 👍

Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd suggest making the docs edit a bit more prominent, but this can be changed later and should not stand in the way of releasing this PR.

@rnorth rnorth merged commit 81317a6 into master Oct 18, 2021
@rnorth rnorth deleted the force_exposed_host branch October 18, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants