-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the usability of GenericContainer #550
Conversation
@bsideup CircleCI failure? https://circleci.com/gh/testcontainers/testcontainers-java/829 |
@@ -383,6 +408,7 @@ default Integer getFirstMappedPort() { | |||
*/ | |||
SELF withLogConsumer(Consumer<OutputFrame> consumer); | |||
|
|||
@Deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this related to the change? Same question for deprecation getContainerInfo()
.
I don't mind deprecating these, as it makes things cleaner, but would it be possible to have a comment indicating a recommended alternative approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the strange CircleCI failures and one minor comment re deprecated methods, otherwise LGTM!
Oops - also, please could you add an entry to the changelog?
@rnorth CircleCI failed because it was using the old configuration: I've added deprecation notes and entries to CHANGELOG.md :) |
1a07fad
to
72f99af
Compare
What was changed:
withEnv
with mapper:READ_WRITE
bind mode if none was provided:Also deprecated some methods from
Container
interface likefetchDockerDaemonInfo
because we don't want to have them in our public API