Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update docker compose image #7989

Closed
wants to merge 1 commit into from
Closed

chore: update docker compose image #7989

wants to merge 1 commit into from

Conversation

rsre
Copy link

@rsre rsre commented Dec 21, 2023

As explained in the docker/compose page:

📣 Docker Compose is now included as part of the Docker official image 🎉

This image contains Compose v1, which has reached end of life (EOL) and is no longer supported. This image’s tags are frozen and are not updated.

This PR switches to the Docker official image which is maintained.

The new image includes an alias to the previous docker-compose command, so everything should keep working as expected.

As explained in the [docker/compose](https://hub.docker.com/r/docker/compose) page:
> 📣 Docker Compose is now included as part of the Docker official image 🎉
>
> This image contains Compose v1, which has reached end of life (EOL) and is no longer supported. This image’s tags are frozen and are not updated.

This PR switches to the Docker official image which is maintained.
@rsre rsre marked this pull request as ready for review December 21, 2023 13:03
@rsre rsre requested a review from a team as a code owner December 21, 2023 13:03
@rsre
Copy link
Author

rsre commented Dec 21, 2023

Looks like the CI failed to download gradle, is it possible to retrigger the CI?

@kiview
Copy link
Member

kiview commented Dec 21, 2023

Hi @rsre, thanks for opening the PR.
This image is already used in ComposeContainer, which represents Docker Compose v2 integration (also see #5608). DockerComposeContainer is still using Docker Compose v1 by design and will be eventually deprecated.

Therefore, I'll close this PR.

@rsre
Copy link
Author

rsre commented Dec 21, 2023

Hi @rsre, thanks for opening the PR. This image is already used in ComposeContainer, which represents Docker Compose v2 integration (also see #5608). DockerComposeContainer is still using Docker Compose v1 by design and will be eventually deprecated.

Therefore, I'll close this PR.

Hi @kiview! I was not aware of that, thanks for pointing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants