Add r2dbc support for Clickhouse #8434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddumelendez
requested changes
Mar 12, 2024
There was a problem hiding this comment.
Thanks for your contribution, @livk-cloud ! Can you please check the comments and please update the docs accordingly.
...clickhouse/src/main/java/org/testcontainers/containers/ClickHouseR2DBCDatabaseContainer.java
Outdated
Show resolved
Hide resolved
modules/clickhouse/src/main/java/org/testcontainers/clickhouse/ClickHouseContainer.java
Outdated
Show resolved
Hide resolved
modules/clickhouse/src/main/java/org/testcontainers/clickhouse/ClickHouseContainer.java
Outdated
Show resolved
Hide resolved
livk-cloud
force-pushed
the
feat-clickhouse-r2dbc
branch
from
09fd62c
to
febf1b2
Compare
livk-cloud
force-pushed
the
feat-clickhouse-r2dbc
branch
from
ae68ce0
to
083dcde
Compare
eddumelendez
changed the title
|
Thanks for your contribution, @livk-cloud! |
This was referenced Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for ClickHouse R2dbc and adjusted the dependency coordinates of clickhouse-jdbc
Fixes #8427