Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump snakeyaml version to 2.2 to eliminate critical CVE-2022-1471 #9462

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ZachChuba
Copy link

Bumping the version of the shaded snakeyaml jar in core from 1.33 to 2.2, as 1.33 is flagged with CVE-2022-1471.

I have read the PR note on raising them just for dependency upgrades, but there have been two new releases since the 30 days ago this issue was raised and the version has not changed, making me suspect dependabot is missing this.

This addresses issue #9289

@ZachChuba ZachChuba requested a review from a team as a code owner October 25, 2024 18:55
@eddumelendez
Copy link
Member

Hi, I am pretty sure you also read my comment #9289 (comment)

@eddumelendez
Copy link
Member

Reopening because snakeyaml is a shaded dependency.

@eddumelendez
Copy link
Member

This snakeyaml version is not compatible with current jackson version

@ZachChuba
Copy link
Author

I would recommend upgrading the jackson version as both this and the current jackson version have critical level security vulnerabilities should be updated... will look into the specific version to bump.

@ZachChuba
Copy link
Author

Upgrading the whole jackson suite to version 2.15.4 would alleviate these vulnerabilities and be compatible with snakeyaml 2.x. However, it appears this shouldn't be changed for backwards compatibility. These severe vulnerabilities will essentially forbid the use of test containers in enterprises with sonatype lifecycle scanning or other security guards.

    // https://youtu.be/otCpCn0l4Wo
    // The core module depends on jackson-databind 2.8.x for backward compatibility.
    // Any >2.8 version here is not compatible with jackson-databind 2.8.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants