hivemq > improve "temp-extensions" workaround #9501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtSilvio
force-pushed
the
hivemq/improve-temp-extensions-workaround
branch
from
a0197ba
to
bede900
Compare
|
Is there any way we can get merge rights if we just touch the hivemq module? |
SgtSilvio
force-pushed
the
hivemq/improve-temp-extensions-workaround
branch
from
bede900
to
c07314e
Compare
SgtSilvio
force-pushed
the
hivemq/improve-temp-extensions-workaround
branch
2 times, most recently
from
982388d
to
101fdab
Compare
- Copy extensions to the temp dir only if required. It is required when removing prepackaged extensions. - Custom copyToContainer calls that specify /opt/hivemq/extensions/... as container path automatically apply the temp dir workaround if required.
- Cleanup code
SgtSilvio
force-pushed
the
hivemq/improve-temp-extensions-workaround
branch
from
101fdab
to
0b1bbeb
Compare
|
@eddumelendez Who should we talk to if we want to become code owners/maintainers of the hivemq module? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support the
withoutPrepackagedExtensionsmethods of theHiveMQContainer, we (HiveMQ) initially built in a workaround that copies extensions into/opt/hivemq/temp-extensions/instead of/opt/hivemq/extensions/and modifies the container entrypoint and command to move the extensions into their right place.We have some upcoming changes to the HiveMQ container images that will remove the need for the
withoutPrepackagedExtensionsmethods in most cases. This change applies the workaround only if any of thewithoutPrepackagedExtensionsmethods are called.This change also makes it easier to use the
withCopyToContainermethod with aTransferableargument to copy files into an HiveMQ extension's folder by just specifying/opt/hivemq/extensions/as containerPath without needing to know about any implementation details. Currently, one is limited to methods likewithFileInExtensionHomeFolderthat apply the "temp-extensions" workaround internally, but these methods only supportMountableFilearguments.