Update MariaDB containers #9554
Conversation
rusher
commented
Nov 25, 2024
rusher
commented
- update connector to recent version
- set default image to current LTS (10.3 is EOL)
- add Foundation image from quay.io: these permit testing preview mariadb images, available 6 months before official release, like new authentication, vector, ...
* update connector to recent version * set default image to current LTS (10.3 is EOL) * add Foundation image from quay.io: these permit testing preview mariadb images, available 6 months before official release, like new authentication, vector, ...
There was a problem hiding this comment.
Hi @rusher, thanks for your contribution. I'left some comments regarding to the changes introduced in this PR. I'm not sure about introducing the image hosted in quay.
| @Deprecated | ||
| public static final String DEFAULT_TAG = "10.3.6"; | ||
| public static final String DEFAULT_TAG = "10.11.10"; |
There was a problem hiding this comment.
default constructor is deprecated and for those using it will bring a new version, which is unexpected. User must declare the version they want to use
| compileOnly 'org.mariadb:r2dbc-mariadb:1.3.0' | ||
|
|
||
| testImplementation project(':jdbc-test') | ||
| testImplementation 'org.mariadb.jdbc:mariadb-java-client:3.4.1' | ||
| testImplementation 'org.mariadb.jdbc:mariadb-java-client:3.5.1' | ||
|
|
||
| testImplementation testFixtures(project(':r2dbc')) | ||
| testRuntimeOnly 'org.mariadb:r2dbc-mariadb:1.0.3' | ||
| testRuntimeOnly 'org.mariadb:r2dbc-mariadb:1.3.0' |
There was a problem hiding this comment.
we use dependabot to update our dependencies. Please revert
| @@ -144,6 +144,18 @@ public void testEmptyPasswordWithRootUser() throws SQLException { | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| public void testFondationImages() throws SQLException { | |||
| try (MariaDBContainer<?> mysql = new MariaDBContainer<>("quay.io/repository/mariadb-foundation/mariadb-devel?tab=tags&tag=11.7").withUsername("root")) { | |||
There was a problem hiding this comment.
any specific reason to declare .withUsername("root")? It's great to have a test, however, quay has had many outages in the past https://status.redhat.com/history. Not sure we want to cause those failures on our CI system.
There was a problem hiding this comment.
Filtering to the quay.io registry component there seems to be one incident in August 2024 since February 2024 when they migrated there. The March 2024 incident looked like deployment rather than pulls.
Did you experience more than these?
There's currently about 300-400 pulls per day on the mariadb-devel image so I'm just hoping its reliable enough for everyone.
| @@ -17,8 +17,10 @@ public class MariaDBContainer<SELF extends MariaDBContainer<SELF>> extends JdbcD | |||
|
|
|||
| private static final DockerImageName DEFAULT_IMAGE_NAME = DockerImageName.parse("mariadb"); | |||
|
|
|||
| private static final DockerImageName FOUNDATION_IMAGE_NAME = DockerImageName.parse("quay.io/repository/mariadb-foundation/mariadb-devel"); | |||
There was a problem hiding this comment.
/repository/ shouldn't be part of this. It won't resolve otherwise:
$ podman pull 'quay.io/repository/mariadb-foundation/mariadb-devel:11.7'
Trying to pull quay.io/repository/mariadb-foundation/mariadb-devel:11.7...
Error: initializing source docker://quay.io/repository/mariadb-foundation/mariadb-devel:11.7: reading manifest 11.7 in quay.io/repository/mariadb-foundation/mariadb-devel: unauthorized: access to the requested resource is not authorized
