fix: properly expose mapped ports #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
DDtKey
pushed a commit
that referenced
this pull request
Apr 29, 2024
## 🤖 New release * `testcontainers`: 0.16.3 -> 0.16.4 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.16.4] - 2024-04-29 ### Details #### Bug Fixes - Properly expose mapped ports ([#610](#610)) #### Features - Introduce `properties-config` cargo feature ([#608](#608)) - Support docker auth configuration for image pulling ([#609](#609)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't auto-map exposed ports as part of port bindings if there are explicit mappings. Otherwise we use
publish_all_portsoption.However, we should auto-expose mapped ports if Image impl doesn't. Because it's a way to override the behavior with
RunnableImage.