fix: get_host for unix and npipe docker hosts
#621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation should be aligned with this impl: https://github.com/testcontainers/testcontainers-java/blob/994b385761dde7d832ab7b6c10bc62747fe4b340/core/src/main/java/org/testcontainers/dockerclient/DockerClientProviderStrategy.java#L451-L467 I.e. we should return `Gateway` only if client running in a container. Otherwise, it's `localhost` for `unix` and `pipe`
Merged
DDtKey
pushed a commit
that referenced
this pull request
May 1, 2024
## 🤖 New release * `testcontainers`: 0.16.6 -> 0.16.7 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.16.7] - 2024-05-01 ### Details #### Bug Fixes - `get_host` for `unix` and `npipe` docker hosts ([#621](#621)) #### Features - Extend `WaitFor` for `ExecCommand` ([#622](#622)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation should be aligned with this impl: https://github.com/testcontainers/testcontainers-java/blob/994b385761dde7d832ab7b6c10bc62747fe4b340/core/src/main/java/org/testcontainers/dockerclient/DockerClientProviderStrategy.java#L451-L467
I.e. we should return
Gatewayonly if client running in a container.Otherwise, it's
localhostforunixandpipe