fix!: use rustls-tls as default for reqwest
#672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`reqwest` exposes a number of TLS-related features, there is no much sense to re-expose them. Cargo features are additive (and reqwest follows this rule), so it's always possible to customize by adding `reqwest` dependency with desired feature-set We can re-consider feature-set provided by `testcontainers` later, but currently we already depend on them through `bollard`: it relies on `rustls` and `rustls-native-certs` It's even possible to make these features optional (e.g when you don't need tls support neither for docker nor reqwest).
✅ Deploy Preview for testcontainers-rust ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Merged
DDtKey
pushed a commit
that referenced
this pull request
Jun 28, 2024
## 🤖 New release * `testcontainers`: 0.18.0 -> 0.19.0 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.19.0] - 2024-06-27 ### Details #### Bug Fixes - [❗] Use `rustls-tls` as default for `reqwest` ([#672](#672)) #### Documentation - Update examples of `GenericImage::with_exposed_port` ([#670](#670)) #### Features - Add ability to convert `ContainerPort` to `u16` ([#664](#664)) #### Miscellaneous Tasks - Make `ports` module public ([#665](#665)) #### Performance - Use separate dropper thread for `current_thread` flavor ([#666](#666)) #### Refactor - Use multi-threaded runtime for blocking feature ([#667](#667)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #671
reqwestexposes a number of TLS-related features, there is no much sense to re-expose them.Cargo features are additive (and reqwest follows this rule), so it's always possible to customize by adding
reqwestdependency with desired feature-setWe can re-consider feature-set provided by
testcontainerslater, but currently we already depend on them throughbollard: it relies onrustlsandrustls-native-certsIt's even possible to make these features optional (e.g when you don't need tls support neither for docker nor reqwest).