This repository has been archived by the owner on Dec 12, 2023. It is now read-only.
feat: add additional information to GetBySubjectDigest #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh, also moved the Store rpc call to the Collector service |
adds collectionName to constrain results by an attestation collection's name. adds more metadata to the search response. Signed-off-by: Mikhail Swift <[email protected]>
fkautz
approved these changes
Jul 7, 2022
| @@ -23,20 +23,21 @@ import "google/protobuf/empty.proto"; | |||
| message GetBySubjectDigestRequest { | |||
| string algorithm = 1; | |||
| string value = 2; | |||
| optional string collectionName = 3; | |||
There was a problem hiding this comment.
Optional is a noop in proto3. All fields are considered optional in the line protocol and code generation. Our application should enforce logic regarding required/optional instead.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds collectionName to constrain results by an attestation collection's
name. adds more metadata to the search response.