Cleanup repo

[MichaelDeBoey]

No description provided.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 21adad1:

Sandbox	Source
determined-sound-wu05q	Configuration

[codecov]

Codecov Report

Merging #459 into beta will not change coverage by %.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              beta      #459   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          412       412           
  Branches        98        98           
=========================================
  Hits           412       412           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fae126...21adad1. Read the comment docs.

[kentcdodds]

Cool, thank you!

[kentcdodds]

@all-contributors please add @MichaelDeBoey for code

[allcontributors]

@kentcdodds

I've put up a pull request to add @MichaelDeBoey! 🎉

[kentcdodds]

🎉 This PR is included in version 7.0.0-beta.4 🎉

The release is available on:

• npm package (@beta dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[NMinhNguyen]

Sorry to be commenting on a merged PR, but any chance the Node v10 requirement could be made a tiny bit lower, e.g. 10.12 (ESLint) or 10.13 (Jest)? Reason being I work in a big corporate where updating to the latest Node version isn't as easy as I would like it to be 😔 I understand that this is not directly this package's problem, but would like to understand why 10.18 specifically and not a bit lower?

[kentcdodds]

Pretty sure we could manage regular node 10 actually

[MichaelDeBoey]

@NMiinhNguyen I've set the minimum requirement to v10.18, because semantic-release@17, requires it
https://github.com/semantic-release/semantic-release/releases/tag/v17.0.0

[kentcdodds]

But we only use semantic release when we're releasing the package and we only do today with node 12

[MichaelDeBoey]

Edit: Whoops wrong library 😅 We're indeed only using it with Node 12, so we should look at all the other dependencies to see which would be the minimum Node version

We do, but users of the travis-release script can make another choice if they want:

// example of a possible .travis.yml

jobs:
  include:
    - stage: release
      node_js: 10.13
      script: kcd-scripts travis-release

[NMinhNguyen]

@MichaelDeBoey as far as the consumption of this library is concerned, semantic-release is not relevant because it's not a direct dependency of this package and is used when releasing only.

[kentcdodds]

In any case, I think Node 10 is the version I want my packages supporting and if we have a dep that prevents that then we should change the dep or did the dep.