fix: Only return first child element in label query

[airjp73]

What:

Bug-Fix: Changes the *ByLabelText queries so that, when finding form controls that are children of labels, only the first form control is returned.

Why:

Following up on the discussion in #373 that started with this comment

How:

When finding children of labels, I filtered the children down to only those that matched the selector and grabbed the first one.

Checklist:

• Documentation added to the
  docs site N/A
• I've prepared a PR for types targeting
  DefinitelyTyped N/A
• Tests
• Ready to be merged

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7cf5496:

Sandbox	Source
vigilant-sara-6b7sf	Configuration

[kentcdodds]

I think this looks good. I doubt this will impact many people, but I would like to get another review from folks on this before it's merged.

[kentcdodds]

Well that's new:

[test]  FAIL   node  src/__node_tests__/index.js
[test]   ● Test suite failed to run
[test] 
[test]     ReferenceError: BigInt is not defined
[test] 
[test]       at createLongLongConversion (node_modules/webidl-conversions/lib/index.js:162:51)
[test]       at Object.<anonymous> (node_modules/webidl-conversions/lib/index.js:224:24)
[test]       at Object.<anonymous> (node_modules/jsdom/lib/jsdom/browser/Window.js:3:27)
[test] 

That's the build failure.

I'm going to open a new issue about this.

[codecov]

Codecov Report

Merging #520 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #520   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          23     23           
  Lines         428    429    +1     
  Branches      102    103    +1     
=====================================
+ Hits          428    429    +1

Impacted Files	Coverage Δ
src/queries/label-text.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 672f231...7cf5496. Read the comment docs.

[kentcdodds]

We won't be able to get this released until #521 is worked out 😬

[kentcdodds]

(Oh, and thanks a lot @airjp73!)

[kentcdodds]

🎉 This PR is included in version 7.2.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[kentcdodds]

Huh, maybe that was a fluke for the build 🤔 😬

[airjp73]

Any time!

[airjp73]

Also, I hope it's not rude to ask 🙃-- could I be added to the all-contributors thing? 😊

[kentcdodds]

Thank you for asking! I'm normally good at doing that but do miss it occasionally. Will get you added now!

[kentcdodds]

@all-contributors please add @airjp73 for code and tests

[allcontributors]

@kentcdodds

I've put up a pull request to add @airjp73! 🎉