Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for aria-disabled attribute #302

Closed
wants to merge 3 commits into from
Closed

Add support for aria-disabled attribute #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4424f1
Add support for aria-disabled attribute
rlaffers Oct 22, 2020
26ac643
Make handling of aria-disabled standards-compliant
rlaffers Oct 22, 2020
7856f11
docs: Fix example for toBeDisabled
rlaffers Oct 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,9 @@ perspective.

It matches if the element is a form control and the `disabled` attribute is
specified on this element or the element is a descendant of a form element with
a `disabled` attribute.
a `disabled` attribute. It also matches if `aria-disabled` attribute of `"true"`
is specified on the element or the element is a descendant of any element with
`aria-disabled="true"` and the element itself is a form control.

According to the specification, the following elements can be
[actually disabled](https://html.spec.whatwg.org/multipage/semantics-other.html#disabled-elements):
Expand All @@ -150,12 +152,18 @@ According to the specification, the following elements can be
<button data-testid="button" type="submit" disabled>submit</button>
<fieldset disabled><input type="text" data-testid="input" /></fieldset>
<a href="..." disabled>link</a>
<div aria-disabled="true" data-testid="generic">generic</div>
<div aria-disabled="true"><input type="text" data-testid="child-input" /></div>
<div aria-disabled="true"><div data-testid="non-focusable-child" /></div>
```

```javascript
expect(getByTestId('button')).toBeDisabled()
expect(getByTestId('input')).toBeDisabled()
expect(getByText('link')).not.toBeDisabled()
expect(getByText('generic')).toBeDisabled()
expect(getByTestId('child-input')).toBeDisabled()
expect(getByTestId('non-focusable-child')).not.toBeDisabled()
```

<hr />
Expand Down Expand Up @@ -239,9 +247,7 @@ This allows you to assert whether an element is present in the document or not.
expect(
getByTestId(document.documentElement, 'html-element'),
).toBeInTheDocument()
expect(
getByTestId(document.documentElement, 'svg-element'),
).toBeInTheDocument()
expect(getByTestId(document.documentElement, 'svg-element')).toBeInTheDocument()
expect(
queryByTestId(document.documentElement, 'does-not-exist'),
).not.toBeInTheDocument()
Expand Down Expand Up @@ -1155,6 +1161,7 @@ Thanks goes to these people ([emoji key][emojis]):

<!-- markdownlint-enable -->
<!-- prettier-ignore-end -->

<!-- ALL-CONTRIBUTORS-LIST:END -->

This project follows the [all-contributors][all-contributors] specification.
Expand Down Expand Up @@ -1205,5 +1212,6 @@ MIT
[emojis]: https://allcontributors.org/docs/en/emoji-key
[all-contributors]: https://github.com/all-contributors/all-contributors
[guiding-principle]: https://testing-library.com/docs/guiding-principles
[discord-badge]: https://img.shields.io/discord/723559267868737556.svg?color=7389D8&labelColor=6A7EC2&logo=discord&logoColor=ffffff&style=flat-square
[discord-badge]:
https://img.shields.io/discord/723559267868737556.svg?color=7389D8&labelColor=6A7EC2&logo=discord&logoColor=ffffff&style=flat-square
[discord]: https://discord.gg/c6JN9fM
Loading