-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(readme): Update the React 18 upgrade docs #841
Conversation
❌ Deploy Preview for react-hooks-testing-library failed.
|
I personally find that this to be confusing & a little superfluous... I think the current description is fine and we probably don't want to inflate the docs further. |
I would have helped me. And it seems I'm not the first it would have helped #832 #826 #842. But if you think it doesn't help others then feel free to close it. |
I spent almost a full day pulling my hair out, as all the tests broke after upgrading - error messages, as always, unhelpful. This may be totally obvious to people who've been working with testing-library for a while - I just dropped into a project and was asked to upgrade react to 18, and I've never used testing-library, so I don't have that context. I had to read through numerous long issues, to finally find the explanation at the end of a long issue thread, pointing to this PR. There's no reason for anyone else to go through that pain - I suggest you get this merged right away. |
Couldn't agree more :) |
Codecov Report
@@ Coverage Diff @@
## main #841 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 245 245
Branches 34 34
=========================================
Hits 245 245 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
What:
Update the React 18 upgrade docs
Why:
To make it easier to upgrade to React 18
How:
To document what the developer can do to upgrade to React 18
Checklist:
I tested it manually on my React project