Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type errors with TypeScript 3.9.7 #240

Closed
blimmer opened this issue Jun 29, 2021 · 3 comments · Fixed by #241
Closed

Type errors with TypeScript 3.9.7 #240

blimmer opened this issue Jun 29, 2021 · 3 comments · Fixed by #241
Labels
bug Something isn't working released

Comments

@blimmer
Copy link
Contributor

blimmer commented Jun 29, 2021

Describe the bug tsc compile fails with Typescript v3.9.7

To Reproduce Steps to reproduce the behavior:

See https://github.com/blimmer/vue-testing-library-issue / https://github.com/blimmer/vue-testing-library-issue/runs/2946243182?check_suite_focus=true

Expected behavior

The Typescript compile should pass with TypeScript v3.

Screenshots

Screen Shot 2021-06-29 at 2 31 48 PM

Related information:

  • @testing-library/vue version: 5.8.0
  • Vue version: N/A
  • node version: 14
  • npm (or yarn) version: N/A

Relevant code or config (if any)

import '@testing-library/vue'

Additional context

Shouldn't the TypeScript check step of the CI system catch this?
@blimmer blimmer added the bug Something isn't working label Jun 29, 2021
@blimmer blimmer mentioned this issue Jun 29, 2021
Merged
@nickserv
Copy link
Member

nickserv commented Jul 6, 2021

Shouldn't the TypeScript check step of the CI system catch this?

See #189

@github-actions
Copy link

github-actions bot commented Jul 6, 2021

🎉 This issue has been resolved in version 5.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

🎉 This issue has been resolved in version 6.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support TypeScript v3 blimmer/vue-testing-library
2 participants
@blimmer @nickserv