Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Enable typecheck #189

Merged
merged 3 commits into from
Jul 30, 2021
Merged

chore(ci): Enable typecheck #189

merged 3 commits into from
Jul 30, 2021

Conversation

afontcu
Copy link
Member

@afontcu afontcu commented Dec 3, 2020

Build won't pass until we find a fix for this: microsoft/dtslint#297 (comment)

update: as @nickmccurdy suggested, switching to tsd did the trick!

@nickserv
Copy link
Member

nickserv commented Jul 6, 2021

Alternatively you may be able to use tsd or ts-expect.

@afontcu
Copy link
Member Author

afontcu commented Jul 6, 2021

Alternatively you may be able to use tsd or ts-expect.

sure, I'll take a look! Thank you for the suggestion

@afontcu afontcu changed the title Enable typecheck chore(ci): Enable typecheck Jul 30, 2021
@afontcu afontcu force-pushed the reenable-typecheck branch from e64a822 to 89c9bd0 Compare July 30, 2021 14:26
@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #189 (89c9bd0) into next (6f1ffbc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              next      #189   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           77        77           
  Branches        27        27           
=========================================
  Hits            77        77           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f1ffbc...89c9bd0. Read the comment docs.

@afontcu
Copy link
Member Author

afontcu commented Jul 30, 2021

I'm merging this, if anyone comes up with a fix for dtslint or a better way to express type testing, I'll be more than happy to review the PR 😃

@afontcu afontcu merged commit 93317d9 into next Jul 30, 2021
@afontcu afontcu deleted the reenable-typecheck branch July 30, 2021 14:43
@github-actions
Copy link

github-actions bot commented Aug 1, 2021

🎉 This PR is included in version 6.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants