Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditorControllerTests TemplateTests path issue #1253

Open
alexwarren opened this issue Nov 30, 2024 · 1 comment
Open

EditorControllerTests TemplateTests path issue #1253

alexwarren opened this issue Nov 30, 2024 · 1 comment

Comments

@alexwarren
Copy link
Contributor

From KV:

It seems that our relative paths don't match. I need it to go up 4 directories to access WorldModel, and you only need to go up 3. I believe you said you had to change it to this to make it work on your machine, and it definitely needs to be the old way on my machine.

Could we maybe be running the tests differently? With the project set to Release, I just use the top menu: Test -> Run all tests

It really doesn't matter, I guess. If this is an issue for anyone, they either (a) can likely figure this out easily on their own or (b) need to learn how to figure things like this out anyway (which was my case, haha). I really just wonder if I'm running the tests correctly. I do see warnings about the test settings when it starts up. (If it didn't take so long for VS to open, I would provide examples.)

EditorControllerTests/TemplateTests.cs

image

@KVonGit
Copy link
Collaborator

KVonGit commented Nov 30, 2024

This may be (and probably is) unrelated, but @Pertex and I had something like this happen (with paths) when we were modifying the file watcher code. 1

System.ArgumentException: Der Verzeichnisname C:\Users\Thomas\AppData\Local\Temp\Core ist ungültig.
   bei System.IO.FileSystemWatcher..ctor(String path, String filter)
   bei TextAdventures.Quest.Editor._Closure$__68-0._Lambda$__0() in C:\Users\kv\Documents\GitHub\quest\Editor\Editor.vb:Zeile 71.

It did that on his machine, but it worked fine on mine. This was that code:

'm_fileWatcherQuest = New System.IO.FileSystemWatcher(Environment.CurrentDirectory + "\Core", "*.aslx")

This worked for both of us, though:

m_fileWatcherQuest = New System.IO.FileSystemWatcher(Application.StartupPath + "\Core", "*.aslx")


I also had to change Ctrl to Control in a few files2 for things to work for him, when they work fine for me either way.

Footnotes

  1. Pertex - Logo and Desktop Icon, DateTime, endWaitDiv, Filewatcher Core #1239

  2. WFEditorTree.resx Ctrl => Control #1241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants