Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFEditorTree.resx Ctrl => Control #1241

Conversation

TextMisadventures
Copy link
Contributor

For internationalization

For internationalization
@alexwarren alexwarren merged commit e27cda6 into textadventures:master Dec 27, 2024
@alexwarren
Copy link
Contributor

Subsequently editing these in Visual Studio has reset this change, so I'm not sure what it was supposed to do...?

@KVonGit
Copy link
Collaborator

KVonGit commented Dec 27, 2024

Odd. It seems to have stuck for Pertex. He said he couldn't build the project at all until after that change, and he's been able to build it successfully ever since.

This is the second or third thing I've noticed that seems to be different between US, UK, and German systems, I think.

@alexwarren
Copy link
Contributor

I see. Just Googled and this explains things: https://stackoverflow.com/questions/59245734/language-problems-with-shortcuts-in-resx-files

@Pertex
Copy link
Collaborator

Pertex commented Dec 28, 2024

Is this problem solved or will it be done with #1306 ?

@KVonGit
Copy link
Collaborator

KVonGit commented Dec 29, 2024

Is this problem solved

I meant to ask you about this, @Pertex. If you clone the textadventures/quest repo right now, can you successfully build the project in VS (now that this PR was merged)?

EDIT
I think Alex created #1306 because he said:

editing these in Visual Studio has reset this change

He then posted this: https://stackoverflow.com/questions/59245734/language-problems-with-shortcuts-in-resx-files

So everything suggests this change shouldn't resolve the issue you originally had.

EDIT 2
I see now. I just made the change and submitted the PR. So it is still Control right now. But once Alex builds the project in VS, it will change that back to Ctrl. Then, the next time he pushes his changes, your issue will return because this file will be updated after having built the project.

@Pertex
Copy link
Collaborator

Pertex commented Dec 29, 2024

I must change Crtl to Control In Menu.resx

@TextMisadventures TextMisadventures deleted the WFEditorTree-Ctrl-to-Control branch January 21, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants