Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the options to change POV or starting room from DevMode in WebEditor breaks everything #1431

Closed
KVonGit opened this issue Feb 12, 2025 · 0 comments · Fixed by #1433
Closed

Comments

@KVonGit
Copy link
Collaborator

KVonGit commented Feb 12, 2025

As soon as you tick either box, the editor crashes. After closing the editor, the game will not reload for editing.

My theory is the WebEditor can't handle this in an editor control:

<simpleeditor>objects</simpleeditor>

NOTES

From Discussion #1430

Important

This user cannot install tje desktop version and has requested the game file be fixed for online use.


When I click "Select another starting location for the player", this happens immediately:

image


And the game will no longer open for editing.


This game attribute getting set seems to be the issue: <devmode_changepovpos />


Uncaught TypeError: refreshTreeSelectElement is undefined
    initialiseElementEditor https://quest.textadventures.co.uk/Scripts/GameEdit.js?c=413940291:242
    initialiseTree https://quest.textadventures.co.uk/Edit/Game/386687:144
    jQuery 10
    initialiseTree https://quest.textadventures.co.uk/Edit/Game/386687:142
    jQuery 11
    selectTreeNode https://quest.textadventures.co.uk/Scripts/GameEdit.js?c=413940291:1223
    initialiseTree https://quest.textadventures.co.uk/Edit/Game/386687:152
    jQuery 21
    initialiseTree https://quest.textadventures.co.uk/Edit/Game/386687:121
    <anonymous> https://quest.textadventures.co.uk/Edit/Game/386687:62
    jQuery 4
GameEdit.js:242:9

DEBUGGING NOTES

This works with no issues in the desktop version of Quest.


The editor controls:

CoreDevMode.aslx L861-L875

    <control>
      <caption>[EditorGameDevModeChangePovPos]</caption>
      <controltype>checkbox</controltype>
      <attribute>devmode_changepovpos</attribute>
      <mustinherit>devmode</mustinherit>
    </control>


    <control>
      <controltype>expression</controltype>
      <simple>[EditorGameDevModePlace]</simple>
      <simpleeditor>objects</simpleeditor>
      <attribute>devmode_povpos</attribute>
      <onlydisplayif>game.devmode_changepovpos</onlydisplayif>
      <mustinherit>devmode</mustinherit>
    </control>

Selecting the option to change POV from DevMode has the same issue online.

I'm wondering if the WebEditor app can handle <simpleeditor>objects</simpleeditor>

KVonGit added a commit to KVonGit/quest that referenced this issue Feb 12, 2025
Closes textadventures#1431

When using DevMode to change starting POV or starting room, the controltype of the object dropdowns crashed the WebEditor and renders the file uneditable online
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant