fix: Click listeners triggers even when swiping

tezro-official · Aug 31, 2021 · 7e741aa · 7e741aa
1 parent a1e8831
commit 7e741aa
Showing 1 changed file with 9 additions and 11 deletions.
diff --git a/library/src/main/java/com/shawnlin/numberpicker/NumberPicker.java b/library/src/main/java/com/shawnlin/numberpicker/NumberPicker.java
@@ -1018,30 +1018,21 @@ public boolean onInterceptTouchEvent(MotionEvent event) {
                 mFlingScroller.forceFinished(true);
                 mAdjustScroller.forceFinished(true);
                 onScrollerFinished(mAdjustScroller);
-            } else if (mLastDownEventX >= mLeftDividerLeft
-                    && mLastDownEventX <= mRightDividerRight) {
-                if (mOnClickListener != null) {
-                    mOnClickListener.onClick(this);
-                }
             } else if (mLastDownEventX < mLeftDividerLeft) {
                 postChangeCurrentByOneFromLongPress(false);
             } else if (mLastDownEventX > mRightDividerRight) {
                 postChangeCurrentByOneFromLongPress(true);
             }
         } else {
-            mLastDownOrMoveEventY = mLastDownEventY = event.getY();
+            mLastDownOrMoveEventY = mLastDownEventY;
+            mLastDownEventY = event.getY();
             if (!mFlingScroller.isFinished()) {
                 mFlingScroller.forceFinished(true);
                 mAdjustScroller.forceFinished(true);
                 onScrollStateChange(OnScrollListener.SCROLL_STATE_IDLE);
             } else if (!mAdjustScroller.isFinished()) {
                 mFlingScroller.forceFinished(true);
                 mAdjustScroller.forceFinished(true);
-            } else if (mLastDownEventY >= mTopDividerTop
-                    && mLastDownEventY <= mBottomDividerBottom) {
-                if (mOnClickListener != null) {
-                    mOnClickListener.onClick(this);
-                }
             } else if (mLastDownEventY < mTopDividerTop) {
                 postChangeCurrentByOneFromLongPress(false);
             } else if (mLastDownEventY > mBottomDividerBottom) {
@@ -1118,6 +1109,9 @@ public boolean onTouchEvent(MotionEvent event) {
                                 changeValueByOne(false);
                             } else {
                                 ensureScrollWheelAdjusted();
+                                if (mOnClickListener != null) {
+                                    mOnClickListener.onClick(this);
+                                }
                             }
                         } else {
                             ensureScrollWheelAdjusted();
@@ -1141,13 +1135,17 @@ public boolean onTouchEvent(MotionEvent event) {
                                 changeValueByOne(false);
                             } else {
                                 ensureScrollWheelAdjusted();
+                                if (mOnClickListener != null) {
+                                    mOnClickListener.onClick(this);
+                                }
                             }
                         } else {
                             ensureScrollWheelAdjusted();
                         }
                         onScrollStateChange(OnScrollListener.SCROLL_STATE_IDLE);
                     }
                 }
+
                 mVelocityTracker.recycle();
                 mVelocityTracker = null;
             }