fix django-polymorphic empty serializer case #1029 #542 #1033
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#542 fixed an assertion error when a sub-serializer had no fields (or only had RO/WO fields).
However, it is a valid case that a sub-serializer may be empty (except for the
resource_type_field
). Usually we would just have an empty body, but here it is a bit more involved. This fix includes that case without building an empty component.@ngnpope fyi since you authored #542, this likely also affects you.