[wip] Universal Module Definition for require.js and friends, namespacing, bower, travis, etc. #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, love the work: I love seeing more stuff pushing the boundary of what browser-based visualization can do.
My original goal here was to get some stuff up and running against the new IPython 2.0 widgets: its system uses require.js, which just wasn't working out with the current build on the site/generated by previous scripts.
I have shimmed in the Univeral Module Definition which pretty much handles the IPython case, as well as whatever people would want to use: seemed like the most expedient way to get to something that works. This mainly means everything is now in the
cola
object that gets exported, so outside of the/src
, it must be used for all the other things that used to be globally exposed by usingcola.v1.min.js
:powergraph
, etc. Obviously a pretty big API change.This lead to fixing up the tests, and in fiddling around with my IPython stuff, making a lean-ish bower definition.
I must confess, I haven't really looked at any of the code in a substantive way, so I am basically banking on the evidence of the tests and examples working again as for this evening's work being "good enough" for this to be a PR worth working towards inclusion, and not just some throw-away hacks.
Since I had spent time on the tests, I set up travis: https://travis-ci.org/bollwyvl/WebCola
Certainly interested in pursuing this further, and welcome any feedback!