Lancet changes to sync with other pipelines #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are changes I'm confident were made previously, but I don't see anything in the commit history. These changes are required in suncity and coyote, but not as much of an effect in phoenix. However it is a cleaner approach than what we have currently, slightly faster as well.
PedalheadPHX
approved these changes
Aug 27, 2020
|
Lancet was the only case as specific as this one. Octopus had similar issues, but applying the reheader along with sorting caused issues in suncity/coyote. However, applying a sort after the concatenation was able to solve the issues in that case. These octopus changes have already been made across all pipelines. No further pull-requests needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are changes I'm confident were made previously, but I don't see anything in the commit history. These changes are required in suncity and coyote, but not as much of an effect in phoenix. However it is a cleaner approach than what we have currently, slightly faster as well.