Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly increment downsample metrics #1259

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Correctly increment downsample metrics #1259

merged 1 commit into from
Jun 18, 2019

Conversation

mattrco
Copy link
Contributor

@mattrco mattrco commented Jun 18, 2019

That'll teach me to copy/paste :)

@brancz
Copy link
Member

brancz commented Jun 18, 2019

Thanks! lgtm 👍

@brancz brancz merged commit d97e310 into thanos-io:master Jun 18, 2019
bwplotka
bwplotka reviewed Jun 18, 2019
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

@brancz
Copy link
Member

brancz commented Jun 18, 2019

There should be some sort of linting possible on these things ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka left review comments

@brancz brancz brancz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattrco @brancz @bwplotka