Move retention at the start of the compactor loop. #2068
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obiesmans
force-pushed
the
retention-before-compaction
branch
2 times, most recently
from
ba8e2d9 to
10a4da2
Compare
daixiang0
reviewed
Jan 29, 2020
obiesmans
force-pushed
the
retention-before-compaction
branch
from
10a4da2 to
ebed8d9
Compare
GiedriusS
requested changes
Jan 31, 2020
|
This issue/PR has been automatically marked as stale because it has not had recent activity. Please comment on status otherwise the issue will be closed in a week. Thank you for your contributions. |
|
Well, sorry I haven't found time to work on this yet ; I'll try to do this next week ! |
|
This issue/PR has been automatically marked as stale because it has not had recent activity. Please comment on status otherwise the issue will be closed in a week. Thank you for your contributions. |
obiesmans
force-pushed
the
retention-before-compaction
branch
3 times, most recently
from
25b4c3a to
7da91fc
Compare
GiedriusS
reviewed
Apr 29, 2020
GiedriusS
reviewed
Apr 29, 2020
GiedriusS
reviewed
Apr 29, 2020
obiesmans
force-pushed
the
retention-before-compaction
branch
2 times, most recently
from
c5ff49a to
8aee515
Compare
Signed-off-by: Olivier Biesmans <[email protected]>
Signed-off-by: Olivier Biesmans <[email protected]>
Signed-off-by: Olivier Biesmans <[email protected]>
Co-Authored-By: Giedrius Statkevičius <[email protected]> Signed-off-by: Olivier Biesmans <[email protected]>
obiesmans
force-pushed
the
retention-before-compaction
branch
3 times, most recently
from
b04e553 to
41cbc8c
Compare
Signed-off-by: Olivier Biesmans <[email protected]>
obiesmans
force-pushed
the
retention-before-compaction
branch
from
41cbc8c to
4a3d45d
Compare
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olivier Biesmans [email protected]
This PR tries to address issue #1708, with the fixes discussed on #1708
Feedback is welcome, especially on how to test those changes.
I added CHANGELOG entry for this change.
Change is not relevant to the end user
Changes
Verification