query: Add e2e test for web route prefix #2714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prem Kumar <[email protected]>
Signed-off-by: Prem Kumar <[email protected]>
squat
approved these changes
Jun 4, 2020
Signed-off-by: Prem Kumar <[email protected]>
squat
reviewed
Jun 8, 2020
squat
approved these changes
Jun 8, 2020
squat
added a commit
to squat/configuration
that referenced
this pull request
Jun 18, 2020
Thanks to thanos-io/thanos#2714, all links in the frontend are now relative. Unfortunately, that means that using `--external-prefix=.` turns `static/x` into `.static/x`, which doesn't exist. We'll fix this here now and then ensure we sanitize this upstream in Thanos. Signed-off-by: Lucas Servén Marín <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prem Kumar [email protected]
Changes
Add a new e2e test scenario for testing route prefix. I used chromedp to test failed network requests. Right now this test would fail, because we are using absolute URLs for static assets in our templates, and hence we get
404 Not Found. This is because we are still trying to get assets from/static/*while it should be/{{ routePrefix }}/static/*as we are using a route prefix.This isn't exactly what we required in #2582 but it serves the same purpose, and is better in some cases. But I think there's still merit in having unit tests for route prefix and similar.
Fixes #2581
Verification
Tested the e2e test by running locally with different scenarios.