Block viewer: Reduce vertical whitespacing #3212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daksh Sagar <[email protected]>
Signed-off-by: Daksh Sagar <[email protected]>
|
I think you need to re-bundle the assets so they can actually be built into the binary, no? |
|
Yes absolutely, doing that. Thanks for pointing it out! |
Signed-off-by: Daksh Sagar <[email protected]>
|
Can you add a screenshot here as well? Will make it easier to review quickly. |
|
Reduced margin b/w the rows, removed the padding and reduced the height of the blocks |
squat
approved these changes
Sep 24, 2020
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daksh Sagar [email protected]
Related to #3112
Changes
Edit blocks.moudle.css to reduce vertical whitespace.
Verification
Verified it in the browser.