-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds duration_ms in int64 to the logs #4509
Conversation
238815c
to
cba3363
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is interesting, I would've just changed duration
to always use a fixed unit but this works too and makes sense 🤗 thx
Please rebase your branch on the latest |
Head branch was pushed to by a user without write access
cba3363
to
b2fbfe0
Compare
@GiedriusS thanks for reviewing this! I just added a CHANGELOG entry and attempted a main rebase, hopefully that fixes the tests. |
afd423f
to
610f8fe
Compare
Signed-off-by: rhassanein <[email protected]>
610f8fe
to
48b242a
Compare
Signed-off-by: rhassanein <[email protected]>
dca285a
to
2e8977a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Sweet! I was just thinking about this :D |
Motivation
Currently the logged lines contain a
duration
field that is encoded as a string with varying units. When ingesting these structured logs into a logging system (eg. elasticsearch), the field is parsed as a string which doesn't allow for range queries.Example from v0.19.0:
Adding a dedicated
duration_ms
integer field solves this problem.Example:
In order to avoid schema conflicts and introducing a breaking change, we're adding a new field rather than changing the existing one.
Changes
Adds an integer
duration_ms
to the logged lines with theduration
field.Verification
@igorwwwwwwwwwwwwwwwwwwww thanks for co-authoring this PR.