Fix querysharding labels analysis #5880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
force-pushed
the
fix-querysharding-analysis
branch
from
a510f1e to
9febb18
Compare
fpetkovski
reviewed
Nov 11, 2022
yeya24
force-pushed
the
fix-querysharding-analysis
branch
from
da319c0 to
5ed0166
Compare
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
yeya24
force-pushed
the
fix-querysharding-analysis
branch
from
5ed0166 to
9c1b74d
Compare
|
Sorry I just fixed the merge conflict. @fpetkovski Could you approve again? Thanks! |
fpetkovski
approved these changes
Nov 11, 2022
|
I will ignore the lint error and merge it if other tests pass. The lint error was introduced by another commit we just merged so let's fix it in another pr. |
3 tasks
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
May 18, 2023
* fix querysharding labels analysis Signed-off-by: Ben Ye <[email protected]> * update changelog Signed-off-by: Ben Ye <[email protected]> * fix lint Signed-off-by: Ben Ye <[email protected]> * update test case Signed-off-by: Ben Ye <[email protected]> Signed-off-by: Ben Ye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Ye [email protected]
Fixes #5879
Changes
Remove the root expression analysis as it is not safe in some edge cases.
Change the sharding labels merge logic when we want to shard by and without at the same time.
Verification