Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates devcontainer dockerfile #7428

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

aritra24
Copy link
Contributor

Fetches the right version of prometheus from
the releases api rather than the tags api
Fixes: #7426

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Makes use of the releases api output rather than tags to fetch prometheus.

Verification

Created a codespace with the new change and it didn't fail.

Fetches the right version of prometheus from
the releases api rather than the tags api

Signed-off-by: Aritra24 <[email protected]>
@saswatamcode saswatamcode enabled auto-merge (squash) June 13, 2024 06:53
@saswatamcode saswatamcode merged commit 3c569da into thanos-io:main Jun 13, 2024
20 checks passed
@aritra24 aritra24 deleted the fix_devcontainer branch June 13, 2024 07:12
hczhu-db pushed a commit to databricks/thanos that referenced this pull request Aug 22, 2024
Fetches the right version of prometheus from
the releases api rather than the tags api

Signed-off-by: Aritra24 <[email protected]>
hczhu-db pushed a commit to databricks/thanos that referenced this pull request Aug 22, 2024
Fetches the right version of prometheus from
the releases api rather than the tags api

Signed-off-by: Aritra24 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codespace doesn't seem to be working
2 participants