Query-frontend: Fix connection to Redis cluster with TLS. #7674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didukh86
force-pushed
the
query_frontend_tls_redis_fix
branch
2 times, most recently
from
c96aaa8 to
cfdf1b7
Compare
didukh86
changed the title
pedro-stanaka
approved these changes
Sep 2, 2024
saswatamcode
previously approved these changes
Sep 2, 2024
|
Added |
didukh86
force-pushed
the
query_frontend_tls_redis_fix
branch
from
e2479b9 to
1a59739
Compare
|
@didukh86 you would need to sign the changelog commit as well. Could you do that, happy to merge then 🙂 |
Issue: thanos-io#7672 Signed-off-by: didukh86 <[email protected]> Signed-off-by: didukh86 <[email protected]> Signed-off-by: didukh86 <[email protected]> Signed-off-by: Taras Didukh <[email protected]>
Signed-off-by: Taras Didukh <[email protected]>
Signed-off-by: Michael Hoffmann <[email protected]>
…tlptracehttp (thanos-io#7666) Bumps [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp](https://github.com/open-telemetry/opentelemetry-go) from 1.27.0 to 1.29.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.27.0...v1.29.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Taras Didukh <[email protected]>
Signed-off-by: milinddethe15 <[email protected]> Signed-off-by: Taras Didukh <[email protected]>
…io#7667) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.2 to 3.26.5. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@429e197...2c779ab) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Taras Didukh <[email protected]>
Bumps [golang.org/x/time](https://github.com/golang/time) from 0.5.0 to 0.6.0. - [Commits](golang/time@v0.5.0...v0.6.0) --- updated-dependencies: - dependency-name: golang.org/x/time dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Taras Didukh <[email protected]>
didukh86
force-pushed
the
query_frontend_tls_redis_fix
branch
from
4888af1 to
75f0328
Compare
Signed-off-by: Taras Didukh <[email protected]>
|
@saswatamcode all commits are signed and all looks fine now. Thank you for reviewing. |
|
Is there anything else missing for this PR to be merged? |
|
@saswatamcode is there something else preventing this PR from approval? |
|
It would be great if we could release this patch soon, please 🙇🏻♂️ We desperately need this fixed |
|
@saswatamcode |
fpetkovski
approved these changes
Nov 28, 2024
2 tasks
saswatamcode
pushed a commit
to saswatamcode/thanos
that referenced
this pull request
Dec 3, 2024
…dis_fix Query-frontend: Fix connection to Redis cluster with TLS.
saswatamcode
pushed a commit
to saswatamcode/thanos
that referenced
this pull request
Dec 3, 2024
…dis_fix Query-frontend: Fix connection to Redis cluster with TLS. Signed-off-by: Saswata Mukherjee <[email protected]>
saswatamcode
added a commit
that referenced
this pull request
Dec 4, 2024
* Merge pull request #7674 from didukh86/query_frontend_tls_redis_fix Query-frontend: Fix connection to Redis cluster with TLS. Signed-off-by: Saswata Mukherjee <[email protected]> * Capnp: Use segment from existing message (#7945) * Capnp: Use segment from existing message Signed-off-by: Filip Petkovski <[email protected]> * Downgrade capnproto Signed-off-by: Filip Petkovski <[email protected]> --------- Signed-off-by: Filip Petkovski <[email protected]> Signed-off-by: Saswata Mukherjee <[email protected]> * [Receive] Fix race condition when adding multiple new tenants at once (#7941) * [Receive] fix race condition Signed-off-by: Yi Jin <[email protected]> * add a change log Signed-off-by: Yi Jin <[email protected]> * memorize tsdb local clients without race condition Signed-off-by: Yi Jin <[email protected]> * fix data race in testing with some concurrent safe helper functions Signed-off-by: Yi Jin <[email protected]> * address comments Signed-off-by: Yi Jin <[email protected]> --------- Signed-off-by: Yi Jin <[email protected]> Signed-off-by: Saswata Mukherjee <[email protected]> * Cut patch release v0.37.1 Signed-off-by: Saswata Mukherjee <[email protected]> * Update promql-engine for subquery fix (#7953) Signed-off-by: Saswata Mukherjee <[email protected]> * Sidecar: Ensure limit param is positive for compatibility with older Prometheus (#7954) Signed-off-by: Saswata Mukherjee <[email protected]> * Update changelog Signed-off-by: Saswata Mukherjee <[email protected]> * Fix changelog Signed-off-by: Saswata Mukherjee <[email protected]> --------- Signed-off-by: Saswata Mukherjee <[email protected]> Signed-off-by: Filip Petkovski <[email protected]> Signed-off-by: Yi Jin <[email protected]> Co-authored-by: Filip Petkovski <[email protected]> Co-authored-by: Yi Jin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7672
Signed-off-by: didukh86 [email protected]
Changes
Added EnableTLS and InsecureSkipVerify to Redis config
Verification
After build I was able to connect to Redis cluster with TLS enabled